Skip to content

🐛 Celery tasks list doesn't include submitted, active and scheduled ones #7366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 14, 2025
Merged

🐛 Celery tasks list doesn't include submitted, active and scheduled ones #7366

merged 6 commits into from
Mar 14, 2025

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Mar 14, 2025 •
edited
Loading

What do these changes do?

Celery task_uuids were not properly returned, when getting them.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Mar 14, 2025
@giancarloromeo giancarloromeo added the bug buggy, it does not work as expected label Mar 14, 2025
@codecov
Copy link

codecov bot commented Mar 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (755a3b2) to head (2d98c9c).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (755a3b2) and HEAD (2d98c9c). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (755a3b2) HEAD (2d98c9c)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7366       +/-   ##
===========================================
- Coverage   87.23%   68.67%   -18.56%     
===========================================
  Files        1705      716      -989     
  Lines       66246    34024    -32222     
  Branches     1124      168      -956     
===========================================
- Hits        57788    23366    -34422     
- Misses       8138    10600     +2462     
+ Partials      320       58      -262
Flag Coverage Δ
integrationtests 65.38% <ø> (+0.04%) ⬆️
unittests 82.51% <75.00%> (-3.88%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.77% <ø> (-12.53%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.10% <ø> (-0.98%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 82.51% <75.00%> (+0.25%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.32% <ø> (-26.49%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755a3b2...2d98c9c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo marked this pull request as ready for review March 14, 2025 14:00
GitHK
GitHK reviewed Mar 14, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great if we could have a test for this

bisgaard-itis
bisgaard-itis approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks a lot. Can't wait for the lake 🌞 ⛵

sanderegg
sanderegg approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
but I agree with @GitHK there need to be some tests

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@giancarloromeo giancarloromeo changed the title 🐛 Fix Celery tasks listing 🐛 Celery tasks list doesn't include submitted, active and scheduled ones Mar 14, 2025
@giancarloromeo giancarloromeo enabled auto-merge (squash) March 14, 2025 21:47
@giancarloromeo giancarloromeo added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 14, 2025
@giancarloromeo giancarloromeo merged commit 5e11322 into ITISFoundation:master Mar 14, 2025
187 of 199 checks passed
@giancarloromeo giancarloromeo deleted the fix-celery-tasks-listing branch March 14, 2025 22:37
@giancarloromeo giancarloromeo added this to the The Awakening milestone Mar 14, 2025
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@giancarloromeo @mrnicegyu11
🐛 Celery tasks list doesn't include submitted, active and `schedu…
88313f4 
…led` ones (ITISFoundation#7366)
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@sanderegg sanderegg sanderegg approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@pcrespov pcrespov Awaiting requested review from pcrespov

Assignees

@giancarloromeo giancarloromeo

Labels

🤖-automerge marks PR as ready to be merged for Mergify bug buggy, it does not work as expected

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

4 participants

@giancarloromeo @GitHK @sanderegg @bisgaard-itis